Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create url lib and fix url slugs #173

Merged
merged 1 commit into from
Apr 13, 2024
Merged

feat: create url lib and fix url slugs #173

merged 1 commit into from
Apr 13, 2024

Conversation

TopETH
Copy link
Member

@TopETH TopETH commented Apr 13, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved URL slug generation to include + and - characters, enhancing support for more complex URLs.

@TopETH TopETH self-assigned this Apr 13, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 13, 2024 •
edited
Loading

Walkthrough

The update involves enhancing the toSlug function in the url.ts file by allowing + and - characters in slugs, aligning with requirements for more inclusive and descriptive URL slugs.

Changes

File Change Summary
.../lib/url.ts Expanded regex in toSlug to include + and - characters.

Possibly related issues

  • Create url lib and fix url slugs #163: This issue discusses creating and fixing URL slugs with specific character requirements, which aligns with the regex update to include + and -.
    • Reasoning: The changes directly support the slug format specifications mentioned in the issue.

Poem

🐇💻
In the land of code, where the slugs must tread,
+ and - now join, where once they fled.
Through paths of URLs, they dance and weave,
A tapestry of links, that browsers receive.
Hoppily coded, by paws so light,
Now URLs shine, ever so bright.
🌟🐰

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7769f4a and ba60d98.
Files selected for processing (1)
  • apps/masterbots.ai/lib/url.ts (1 hunks)
Additional comments not posted (1)
apps/masterbots.ai/lib/url.ts (1)

14-14: Ensure the new regular expression in toSlug handles edge cases as expected.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel Vercel
Copy link

vercel bot commented Apr 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
masterbots ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 2:59am

@TopETH TopETH mentioned this pull request Apr 13, 2024
Closed
@TopETH TopETH linked an issue Apr 13, 2024 that may be closed by this pull request
Create url lib and fix url slugs #163
Closed
@github-actions GitHub Actions
Copy link

⚡️ Lighthouse report

Page: https://masterbots-fg9ng3xns-bitcash.vercel.app/
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712977639683-99463.report.html

Category Score
🟠 Performance 50
🟢 Accessibility 96
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-fg9ng3xns-bitcash.vercel.app/b/moneybot
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712977640048-13144.report.html

Category Score
🟠 Performance 53
🟢 Accessibility 96
🟠 Best practices 78
🟠 SEO 85
🔴 PWA 38

Page: https://masterbots-fg9ng3xns-bitcash.vercel.app/u/slug-1
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712977640634-24849.report.html

Category Score
🟠 Performance 58
🟢 Accessibility 94
🟠 Best practices 78
🟠 SEO 83
🔴 PWA 38

Page: https://masterbots-fg9ng3xns-bitcash.vercel.app/p
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712977640978-22288.report.html

Category Score
🟠 Performance 88
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 76
🔴 PWA 38

Page: https://masterbots-fg9ng3xns-bitcash.vercel.app/health
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712977641358-86739.report.html

Category Score
🟠 Performance 88
🟠 Accessibility 59
🟠 Best practices 74
🔴 SEO 42
🔴 PWA 13

Page: https://masterbots-fg9ng3xns-bitcash.vercel.app/health/a8103808-14a3-48ed-aa5a-9e490cfdcf0e
Report https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1712977641740-93326.report.html

Category Score
🟠 Performance 89
🟠 Accessibility 59
🟠 Best practices 74
🔴 SEO 42
🔴 PWA 13

@gaboesquivel gaboesquivel merged commit e8dda27 into alpha Apr 13, 2024
4 checks passed
@gaboesquivel gaboesquivel deleted the topeth/create-url-lib-and-fix-url-slugs-#163 branch April 13, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaboesquivel gaboesquivel gaboesquivel approved these changes

Assignees

@TopETH TopETH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create url lib and fix url slugs
2 participants
@TopETH @gaboesquivel